Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization dependent components #1435

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Optimization dependent components #1435

merged 1 commit into from
Mar 28, 2023

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Mar 28, 2023
@GuoLei1990 GuoLei1990 added this to the 1.0 milestone Mar 28, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 53.84% and project coverage change: +0.19 🎉

Comparison is base (68c26cd) 48.95% compared to head (7967fd2) 49.14%.

❗ Current head 7967fd2 differs from pull request most recent head af2464c. Consider uploading reports for the commit af2464c to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev/1.0    #1435      +/-   ##
===========================================
+ Coverage    48.95%   49.14%   +0.19%     
===========================================
  Files          363      363              
  Lines        18453    18446       -7     
  Branches      2644     2645       +1     
===========================================
+ Hits          9033     9066      +33     
+ Misses        8485     8447      -38     
+ Partials       935      933       -2
Impacted Files Coverage Δ
packages/core/src/2d/sprite/SpriteMask.ts 40.69% <ø> (ø)
packages/core/src/2d/sprite/SpriteRenderer.ts 32.25% <ø> (ø)
packages/core/src/Camera.ts 55.45% <ø> (+5.21%) ⬆️
packages/core/src/Renderer.ts 55.08% <ø> (ø)
packages/core/src/mesh/BlendShapeManager.ts 53.13% <ø> (ø)
packages/core/src/physics/Collider.ts 48.93% <ø> (ø)
packages/core/src/physics/joint/Joint.ts 2.32% <ø> (ø)
packages/core/src/shader/ShaderData.ts 77.48% <ø> (ø)
packages/core/src/shader/ShaderPart.ts 85.71% <0.00%> (ø)
packages/core/src/shader/ShaderProgram.ts 52.08% <ø> (ø)
... and 4 more

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

zhuxudong
zhuxudong approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@zhuxudong zhuxudong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@GuoLei1990 GuoLei1990 merged commit 4d5ed09 into galacean:dev/1.0 Mar 28, 2023
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Mar 28, 2023
@GuoLei1990
Merge commit '4d5ed09b3ac3cf728fcb63bff0376cc44a4ddaee' into pr/engin…
778ea3f 
…e-asyc-create

* commit '4d5ed09b3ac3cf728fcb63bff0376cc44a4ddaee':
  feat: opt ComponentsDependencies (galacean#1435)
  Optimization shader part of the code (galacean#1428)
@GuoLei1990 GuoLei1990 linked an issue Mar 28, 2023 that may be closed by this pull request
Component dependency to manager the relation between them #479
Open
@GuoLei1990 GuoLei1990 mentioned this pull request Mar 28, 2023
Closed
37 tasks
@GuoLei1990 GuoLei1990 deleted the pr/opt-dependentComponents branch September 18, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuxudong zhuxudong zhuxudong approved these changes

Assignees
No one assigned
Labels
ignore for release ignore for release
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Component dependency to manager the relation between them
3 participants
@GuoLei1990 @codecov-commenter @zhuxudong